Full Head life cycle from TUI #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the client to give better feedback, but complicates (simulated) chain implementation slightly. Also includes necessary updates to tests and API spec.
ch1bo
force-pushed
the
ch1bo/tui-full-lifecycle
branch
from
c48a741
to
35eddc0
Compare
|
|
ch1bo
requested review from
KtorZ and
abailly-iohk
and removed request for
KtorZ
abailly-iohk
reviewed
Sep 1, 2021
There was a problem hiding this comment.
I understand the point of providing some feedback to the user, but given the fact the TUI is an artefact used for demo purpose, I would do this calculation in the client and keep the internals as it is, eg. use a DiffTime and not an absolute UTCTime. I am unsure what time really means in a Head and even more so in relationship with the main chain.
I think worthwhile to discuss this together IRL rather than through Github comments system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very basic in what it displays and it also only allows to commit an empty
Utxoset.I'd like to highlight the changes in 35eddc0 and welcome any feedback. In the logbook are some notes on what I though when implementing this.