Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider internal representation of FsPaths #68

Open
jorisdral opened this issue May 31, 2024 · 0 comments
Open

Reconsider internal representation of FsPaths #68

jorisdral opened this issue May 31, 2024 · 0 comments

Comments

@jorisdral
Copy link
Collaborator

jorisdral commented May 31, 2024

The current FsPath representation as [Text] is not very ergonomic. We should reconsider whether we want to pick a different internal representation, maybe something like an OsPath or Vector.

If we pick OsPath (or even FilePath) as the internal representation, with sufficient invariants to ensure that they form sensible relative paths, then we could probably simplify the implementation of a number of FsPath combinator and conversion functions. For example, (</>) on FsPaths could be a simple wrapper around (</>) on OsPaths/FilePaths. FilePaths would, however, probably not be more performant than the current [Text] representation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant