Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'slotRatio' case where the numerator is further than the denominator #234

Merged
merged 1 commit into from
May 8, 2019
Merged

fix 'slotRatio' case where the numerator is further than the denominator #234

merged 1 commit into from
May 8, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented May 7, 2019

Issue Number

Overview

  • I have fixed 'slotRatio' case where the numerator is further than the denominator
  • I have added a property tests to control that too

Comments

@KtorZ KtorZ requested a review from akegalj May 7, 2019 14:33
@KtorZ KtorZ self-assigned this May 7, 2019
paweljakubas
paweljakubas approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akegalj
akegalj approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@akegalj akegalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it now. LGTM

@KtorZ KtorZ merged commit 25b6284 into master May 8, 2019
@KtorZ KtorZ deleted the KtorZ/fix-slot-ratio branch May 8, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akegalj akegalj akegalj approved these changes

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KtorZ @akegalj @paweljakubas