Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide clearer failure-reason when wallet is not syncing #193

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

Anviking
Copy link
Member

Overview

  • I have used a custom failure reason for A newly created wallet can sync with the chain

Comments

Previously (note the "predicate failed"):

  test/integration/Cardano/WalletSpec.hs:53:13:
  1) Cardano.WalletSpec A newly created wallet can sync with the chain
       predicate failed on: SlotId {epochNumber = 0, slotNumber = 0}

Now:

  test/integration/Cardano/WalletSpec.hs:56:17:
  1) Cardano.WalletSpec A newly created wallet can sync with the chain
       The wallet tip is still SlotId {epochNumber = 0, slotNumber = 0}

@Anviking Anviking requested a review from KtorZ April 29, 2019 13:42
@Anviking Anviking self-assigned this Apr 29, 2019
@KtorZ
Copy link
Member

KtorZ commented Apr 29, 2019

@Anviking Have you ran into this failure locally 🤔 ?

@KtorZ KtorZ merged commit 6bb1b8d into master Apr 29, 2019
@KtorZ KtorZ deleted the anviking/tweak-test-output branch April 29, 2019 16:43
@Anviking
Copy link
Member Author

Yes

@Anviking
Copy link
Member Author

Likely because I was working on the TxWitness decoder, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants