Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup socket file path code #5215

Merged
merged 3 commits into from
May 10, 2023
Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 10, 2023

Description

  • Delete Cardano.Api.Environment module.
  • Merge two SocketPath type definitions to the one defined in Cardano.Api.IO
  • Delete EnvSocketError and associated functions and types

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/cleanup-socket-file-path-code branch 3 times, most recently from fc2a214 to b24457f Compare May 10, 2023 13:25
@newhoggy newhoggy force-pushed the newhoggy/cleanup-socket-file-path-code branch from b24457f to 4987672 Compare May 10, 2023 22:46
@newhoggy newhoggy enabled auto-merge May 10, 2023 22:51
@newhoggy newhoggy added this pull request to the merge queue May 10, 2023
Merged via the queue into master with commit ee78fea May 10, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/cleanup-socket-file-path-code branch May 10, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants