Golden tests for cardano-api errors
#5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
a team,
deepfire,
mgmeier,
fmaste,
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/golden-tests-for-errors
branch
2 times, most recently
from
0d1960e
to
17c18a8
Compare
newhoggy
commented
May 4, 2023
| -- { Qry.pastHorizonCallStack = GHC.callStack | ||
| -- , Qry.pastHorizonExpression = error "" -- Some $ Qry.ClosedExpr $ Qry.ELit 0 | ||
| -- , Qry.pastHorizonSummary = [] | ||
| -- } |
There was a problem hiding this comment.
Need some way to construct a constant PastHorizonException value.
erikd
approved these changes
May 4, 2023
carbolymer
approved these changes
May 4, 2023
newhoggy
force-pushed
the
newhoggy/golden-tests-for-errors
branch
3 times, most recently
from
1e6b652
to
5f1b788
Compare
Jimbo4350
approved these changes
May 8, 2023
| @@ -5,6 +5,13 @@ | |||
|
|
|||
| ### Features | |||
|
|
|||
| - New error exports: | |||
There was a problem hiding this comment.
We need to be able to construct errors in order to test how they display.
newhoggy
force-pushed
the
newhoggy/golden-tests-for-errors
branch
from
5f1b788
to
e933b5d
Compare
fmaste
approved these changes
May 9, 2023
newhoggy
force-pushed
the
newhoggy/golden-tests-for-errors
branch
from
e933b5d
to
3b98748
Compare
newhoggy
force-pushed
the
newhoggy/golden-tests-for-errors
branch
from
ee30868
to
c6429f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add golden tests for API errors.
By maintaining a set of golden test files for our error message output, we gain the ability to have a technical writer review our error messages to ensure they are optimal and allow us to refactor the way we generate error messages to minimise risk and ensure progress (vs regression).
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.