UTC Time to slots conversion function #5130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
commented
Apr 20, 2023
carbolymer
force-pushed
the
mgalazyn/feature/get-slot-from-timestamp
branch
from
d3bf90c
to
5a7f583
Compare
carbolymer
force-pushed
the
mgalazyn/feature/get-slot-from-timestamp
branch
from
5a7f583
to
5b6fd2f
Compare
carbolymer
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
reviewed
Apr 24, 2023
newhoggy
reviewed
Apr 25, 2023
newhoggy
approved these changes
Apr 25, 2023
newhoggy
reviewed
Apr 25, 2023
Jimbo4350
approved these changes
Apr 25, 2023
newhoggy
reviewed
Apr 26, 2023
newhoggy
reviewed
Apr 26, 2023
|
I think this can be one commit, or two commits: one for api changes and one for cli changes. |
carbolymer
force-pushed
the
mgalazyn/feature/get-slot-from-timestamp
branch
from
19a85b5
to
55b14d2
Compare
newhoggy
approved these changes
Apr 26, 2023
Jimbo4350
approved these changes
Apr 26, 2023
| @@ -1422,6 +1424,41 @@ toTentativeEpochInfo (EraHistory _ interpreter) = | |||
| $ hoistEpochInfo (first (Text.pack . show) . runExcept) | |||
| $ Consensus.interpreterToEpochInfo (Consensus.unsafeExtendSafeZone interpreter) | |||
|
|
|||
|
|
|||
| -- | Get slot number for timestamp, or an error if the UTC timestamp is before 'SystemStart' or after N+1 era | |||
There was a problem hiding this comment.
N being the current era right?
There was a problem hiding this comment.
Yes, this function should work for current and next eras.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a part of #4928 . This changeset introduces a conversion function: UTC time -> slot number.
The function was tested in #5142
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlfor to get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlfor to get thestylish-haskellversion