Remove non-round-trippable value TxInsReferenceNone for babbage onwards in generator #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
carbolymer
approved these changes
Apr 6, 2023
newhoggy
force-pushed
the
newhoggy/remove-non-round-trippable-value-TxInsReferenceNone-for-babbage-onwards
branch
2 times, most recently
from
901aae2
to
a2810e0
Compare
newhoggy
force-pushed
the
newhoggy/remove-non-round-trippable-value-TxInsReferenceNone-for-babbage-onwards
branch
from
a2810e0
to
8a24662
Compare
erikd
approved these changes
Apr 12, 2023
iohk-bors
bot
deleted the
newhoggy/remove-non-round-trippable-value-TxInsReferenceNone-for-babbage-onwards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eras where
TxInsReferenceis supported it is mandatory in the ledger.We can't have both
Just []andNonerepresent the same ledger value or round tripping can't work.We will choose
Just []as the to represent the ledger's empty list value for this field.