Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SerialiseAsRawBytes type class #4876

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Simplify SerialiseAsRawBytes type class #4876

merged 1 commit into from
Feb 11, 2023

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy changed the title Delete old deserialiseFromRawBytes method. Rename EeitherDeserialiseFromRawBytes to deserialiseFromRawBytes Delete old deserialiseFromRawBytes method. Rename EitherDeserialiseFromRawBytes to deserialiseFromRawBytes Feb 10, 2023
@newhoggy newhoggy force-pushed the newhoggy/simplify-SerialiseAsRawBytes branch from d0effd0 to f485704 Compare February 10, 2023 04:18
@newhoggy newhoggy marked this pull request as ready for review February 10, 2023 04:18
erikd
erikd previously requested changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eitherDeserialiseFromRawBytes must have a deprecation warning.

@newhoggy newhoggy force-pushed the newhoggy/simplify-SerialiseAsRawBytes branch from f485704 to dc9f954 Compare February 10, 2023 05:32
@newhoggy newhoggy requested a review from erikd February 10, 2023 05:32
@newhoggy newhoggy dismissed erikd’s stale review February 10, 2023 05:32

Deprecation added

@newhoggy newhoggy force-pushed the newhoggy/simplify-SerialiseAsRawBytes branch from dc9f954 to ad992ed Compare February 10, 2023 05:36
@newhoggy newhoggy changed the title Delete old deserialiseFromRawBytes method. Rename EitherDeserialiseFromRawBytes to deserialiseFromRawBytes Simplify SerialiseAsRawBytes type class Feb 10, 2023
Jimbo4350
Jimbo4350 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a bit more context to the commit message?

@newhoggy
Simplify SerialiseAsRawBytes type class.
a30099c 
`deserialiseFromRawBytes` method of the `SerialiseAsRawBytes` type class to return `Either` instead of `Maybe`. Deprecate `eitherDeserialiseFromRawBytes`. Use `deserialiseFromRawBytes` instead.
@newhoggy newhoggy force-pushed the newhoggy/simplify-SerialiseAsRawBytes branch from ad992ed to a30099c Compare February 10, 2023 18:10
@newhoggy
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 11, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 75130f1 into master Feb 11, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/simplify-SerialiseAsRawBytes branch February 11, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @erikd @Jimbo4350