Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export SubmitResult from Cardano.Api #4753

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Export SubmitResult from Cardano.Api #4753

merged 1 commit into from
Jan 11, 2023

Conversation

MarcFontaine
Copy link
Contributor

@MarcFontaine MarcFontaine commented Jan 6, 2023 •
edited
Loading

Resolves: #4716

@MarcFontaine MarcFontaine self-assigned this Jan 6, 2023
@MarcFontaine
Copy link
Contributor Author

#4716

@MarcFontaine MarcFontaine mentioned this pull request Jan 6, 2023
Closed
Jimbo4350
Jimbo4350 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you put "Resolves: #{issueNumer}" in the description?

@Jimbo4350 Jimbo4350 merged commit ecebf79 into master Jan 11, 2023
@iohk-bors iohk-bors bot deleted the mafo/4716-export-submit-result branch January 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees

@MarcFontaine MarcFontaine

Labels
Client API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Re-Export SubmitResult from Cardano.Api.IPC in Cardano.Api
2 participants
@MarcFontaine @Jimbo4350