[cardano-api] Derive Eq instance for AcquiringFailure #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch1bo
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Nov 30, 2022
This is to work around a missing Eq AcquiringFailure, see IntersectMBO/cardano-node#4683
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Nov 30, 2022
This is to work around a missing Eq AcquiringFailure, see IntersectMBO/cardano-node#4683
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Nov 30, 2022
This is to work around a missing Eq AcquiringFailure, see IntersectMBO/cardano-node#4683
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Nov 30, 2022
This is to work around a missing Eq AcquiringFailure, see IntersectMBO/cardano-node#4683
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Nov 30, 2022
This is to work around a missing Eq AcquiringFailure, see IntersectMBO/cardano-node#4683
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Nov 30, 2022
This is to work around a missing Eq AcquiringFailure, see IntersectMBO/cardano-node#4683
Jimbo4350
reviewed
Dec 8, 2022
| @@ -14,6 +14,8 @@ | |||
|
|
|||
| - **Breaking change** - Reduce exposed modules in cardano-api ([PR4546](https://github.com/input-output-hk/cardano-node/pull/4546)) | |||
|
|
|||
| - **Breaking change** Change return type of `queryNodeLocalState` to new `AcquiringFailure` type. | |||
There was a problem hiding this comment.
Where is this breaking change?
There was a problem hiding this comment.
It was a breaking change. I intended to document the fact and why I ended up doing this PR -> our code down stream broke.
newhoggy
approved these changes
Mar 1, 2023
newhoggy
force-pushed
the
ch1bo/cardano-api-acquiring-failure-eq-instance
branch
from
9d98394
to
a339626
Compare
This is often used in tests where we would like to assert that we receive one or the other.
newhoggy
force-pushed
the
ch1bo/cardano-api-acquiring-failure-eq-instance
branch
from
a339626
to
3f7b997
Compare
iohk-bors
bot
deleted the
ch1bo/cardano-api-acquiring-failure-eq-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is often used in tests where we would like to assert that we receive one or the other.