Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cardano Node 1.35.6 aka Single Relay P2P release #4612

Merged
merged 15 commits into from
Feb 4, 2023
Merged

Cardano Node 1.35.6 aka Single Relay P2P release #4612

merged 15 commits into from
Feb 4, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Nov 3, 2022 •
edited
Loading

@coot coot force-pushed the coot/release-1.35.5 branch 2 times, most recently from 4460c07 to 449d2aa Compare November 4, 2022 13:41
@coot coot mentioned this pull request Nov 7, 2022
Merged
@daehan-koreapool
Copy link

@coot
Hi Marcin,

In the spo-announcements discord channel, you've informed P2P relay should be included in the registration cert.
As a SPO, I've been running multiple hidden relays for security reasons.

Does this mean all the hidden relays need to be exposed publicly by including their DNS records in pool certs?

If not, would you be able to elaborate a bit more on what you mean by

We would like to ask you to double check that your registration certificates contains valid domain names, otherwise other relays will not be able to communicate with your relays, and thus your blocks will not be delivered through the P2P relay.

@coot coot marked this pull request as ready for review November 10, 2022 13:13
@coot
Copy link
Contributor Author

coot commented Nov 10, 2022

@daehan-koreapool it's ok to run hidden relays; as with non-P2P mode their downstream peers need to be explicitly configured to connect to your hidden relay(s).

The reminder is just to double check that your on chain registered relays have valid DNS names.

Jimbo4350
Jimbo4350 previously requested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. There are some commits that can be squashed together to clean up the git history.

cardano-node/ChangeLog.md Show resolved Hide resolved
cardano-node/cardano-node.cabal Outdated Show resolved Hide resolved
@coot coot force-pushed the coot/release-1.35.5 branch 3 times, most recently from 80f863d to 4161a7e Compare November 24, 2022 13:05
@coot
Copy link
Contributor Author

coot commented Nov 24, 2022

I had to pin all ledger packages, since new versions where published to CHaP and I need a newer CHaP to get newer versions of ouroboros-network & ouroboros-consensus.

@coot coot force-pushed the coot/release-1.35.5 branch 2 times, most recently from dbe2d29 to 3cda6f4 Compare November 24, 2022 20:36
@andreabedini
Copy link
Contributor

andreabedini commented Nov 24, 2022 •
edited
Loading

I had to pin all ledger packages, since new versions where published to CHaP and I need a newer CHaP to get newer versions of ouroboros-network & ouroboros-consensus.

These are direct depedencies and you should put the constraint in the cabal file itself, not in the cabal.project. Rememeber that cabal.project is not published only (e.g.) cardano-api.cabal is.

PS: I am aware that this might not be enough since other packages in CHaP have missing bounds on their dependenceis, but at least it's a step in the right direction.

@coot
Copy link
Contributor Author

coot commented Nov 25, 2022

The haddock build is fixed in #4662.

@coot
Copy link
Contributor Author

coot commented Nov 25, 2022

These are direct depedencies and you should put the constraint in the cabal file itself, not in the cabal.project. Rememeber that cabal.project is not published only (e.g.) cardano-api.cabal is.

I agree 💯, although I think a suitable solution should be found by the node team in master. @Jimbo4350 @JaredCorduan what do you think?

network packages are pinned in *.cabal files, although it can be improved.

@coot
Copy link
Contributor Author

coot commented Nov 25, 2022

@andreabedini I opened an issue for this #4663.

@jbgi
Copy link
Contributor

jbgi commented Jan 19, 2023

bors try

iohk-bors bot added a commit that referenced this pull request Jan 19, 2023
@iohk-bors
Try #4612:
e93c695
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 19, 2023

try

Build succeeded:

@coot coot changed the title Cardano Node 1.35.5 aka Single Relay P2P release Cardano Node 1.35.6 aka Single Relay P2P release Jan 27, 2023
@coot coot dismissed Jimbo4350’s stale review February 2, 2023 13:08

The review was addressed.

michaelpj and others added 15 commits February 3, 2023 16:20
@michaelpj @coot
Bump CHaP, remove unneded s-r-ps
ef00cd2
@coot
Updated cardano-node for 1.35.6 release
58cf199
@coot
New topology file format
94e7f59
@coot
Added test of p2p topology decoder
63a2e62 
Test p2p topology decoder by generating valid encodings.
@coot
Expanded installation instructions
737fc13
@coot
Removed P2PWarningDevelopmentNetworkProtocols
8423e85 
The warning is not needed as of ouroboros-network#3859.
@coot
Modify P2PWarning message
1fa71fa 
P2P is now an early release: we encourage to enable it on at most one of
the relays (if one has more than one relay).  We don't advise yet to use
it on BP nodes.
@coot
Reword where to get peers from in understanding-config-files.md
dd21f2c 
Fixes input-output-hk/ouroboros-network#3691
@coot
Bump CHaP, remove not needed r-s-p stanzas
4003eb3
@coot
Upgrade to ouroboros-network-0.3.0.0
9014235 
* ouroboros-network-0.3.0.0
* ouroboros-consensus-0.1.0.3
* ouroboros-consensus-cardano-0.2.0.0
@coot
NodeToNodeVersion and NodeToClientVersion JSON instances
de49aaa
@coot
Split WarningDevelopmentNetworkProtocolVersions
4bc88da 
Split it into node-to-node and node-to-node. This is needed so that the
log contains information whether the version numbers (now encoded as
numbers) are node-to-node or node-to-client version.

I also realised that that constructor is never traced, the same is true
for other constructors of the tracer.
@coot
Updated ChangeLog.md file of cardano-node
b5599d5
@coot
Fixed hlint
05644a6
@coot
bump version to 1.35.6
7152517
@disassembler
Copy link
Contributor

bors try

iohk-bors bot added a commit that referenced this pull request Feb 3, 2023
@iohk-bors
Try #4612:
63a4e16
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 3, 2023

try

Build succeeded:

@coot
Copy link
Contributor Author

coot commented Feb 4, 2023

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 4, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 037542e into release/1.35 Feb 4, 2023
@iohk-bors iohk-bors bot deleted the coot/release-1.35.5 branch February 4, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbgi jbgi jbgi approved these changes

@deepfire deepfire Awaiting requested review from deepfire

@jutaro jutaro Awaiting requested review from jutaro jutaro is a code owner

@mgmeier mgmeier Awaiting requested review from mgmeier mgmeier is a code owner

@MarcFontaine MarcFontaine Awaiting requested review from MarcFontaine

@cleverca22 cleverca22 Awaiting requested review from cleverca22 cleverca22 is a code owner

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

Assignees
No one assigned
Labels
area: p2p
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@coot @daehan-koreapool @andreabedini @gitmachtl @jbgi @disassembler @Jimbo4350 @michaelpj