Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce exposed modules in cardano-api #4546

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Reduce exposed modules in cardano-api #4546

merged 3 commits into from
Nov 2, 2022

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350 Jimbo4350 force-pushed the jordan/cardano-api-refactor-reduce-exposed-modules branch from 0b49e5e to da08513 Compare October 20, 2022 15:47
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 20, 2022 15:47
@LudvikGalois
Copy link
Contributor

Given that this is a breaking change for downstream users of the API, should there be a note in the changelog about it?

@JaredCorduan
Copy link
Contributor

Given that this is a breaking change for downstream users of the API, should there be a note in the changelog about it?

I would hope so myself!

@Jimbo4350
Copy link
Contributor Author

Yep definitely. I'll update the changelog.

@Jimbo4350 Jimbo4350 force-pushed the jordan/cardano-api-refactor-reduce-exposed-modules branch from 6e5d694 to 3e376b3 Compare October 26, 2022 09:37
@Jimbo4350 Jimbo4350 force-pushed the jordan/cardano-api-refactor-reduce-exposed-modules branch from 3e376b3 to a242326 Compare October 26, 2022 11:09
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 26, 2022
@iohk-bors @Jimbo4350
Merge #4546
fb95b94 
4546: Reduce exposed modules in cardano-api r=Jimbo4350 a=Jimbo4350



Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 26, 2022

Build failed:

@Jimbo4350 Jimbo4350 force-pushed the jordan/cardano-api-refactor-reduce-exposed-modules branch from a242326 to a822aee Compare October 31, 2022 17:43
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 31, 2022
@iohk-bors @Jimbo4350
Merge #4546
6eb408a 
4546: Reduce exposed modules in cardano-api r=Jimbo4350 a=Jimbo4350



Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 31, 2022

Build failed:

@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 31, 2022
@iohk-bors @Jimbo4350
Merge #4546
f11022b 
4546: Reduce exposed modules in cardano-api r=Jimbo4350 a=Jimbo4350



Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 31, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@deepfire
Copy link
Contributor

deepfire commented Nov 1, 2022

bors r+

1 similar comment
@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 1, 2022

Already running a review

@Jimbo4350 Jimbo4350 mentioned this pull request Nov 1, 2022
Merged
iohk-bors bot added a commit that referenced this pull request Nov 1, 2022
@iohk-bors @Jimbo4350
Merge #4546 #4587
84d9a4b 
4546: Reduce exposed modules in cardano-api r=deepfire a=Jimbo4350



4587: Add Ord instance for AddressInEra r=Jimbo4350 a=Jimbo4350

Co-authored-by: `@UlfNorell`

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 1, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, fmaste, input-output-hk/devops, jutaro, mgmeier, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

MarcFontaine
MarcFontaine approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcFontaine
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 2, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit acf0859 into master Nov 2, 2022
@iohk-bors iohk-bors bot deleted the jordan/cardano-api-refactor-reduce-exposed-modules branch November 2, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@deepfire deepfire deepfire approved these changes

@MarcFontaine MarcFontaine MarcFontaine approved these changes

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

@mgmeier mgmeier Awaiting requested review from mgmeier

@fmaste fmaste Awaiting requested review from fmaste

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jimbo4350 @LudvikGalois @JaredCorduan @deepfire @MarcFontaine @newhoggy