feat: ensure qsg works 1.19.1 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mineme0110
reviewed
Jan 26, 2024
Comment on lines
257
to
+280
|
|
||
| 2. Run the following commands: | ||
| 2. Ensure you have all applications installed for building the SDK and it's dependencies | ||
|
|
||
| [rust](https://www.rust-lang.org/tools/install) and [wasm-pack](https://rustwasm.github.io/wasm-pack/installer/) are leveraged to build and use the AnonCreds and DIDComm rust libraries within typescript. To build the SDK locally or run demonstration applications, you must have these applications installed. | ||
|
|
||
| The following should work Linux and MacOS, if you experience any issues - please check the latest installation instructions for your platform. | ||
|
|
||
| ``` | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh | ||
| curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Maybe this instructions should be prior to cloning the repo and if there was an old repo already cloned , Then delete repo and then follow the above steps, I think that would be much cleaner
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
…o example Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
mineme0110
force-pushed
the
feature/ensure-qsg-works-1.19.1
branch
from
dc5f7af to
ab3c220
Compare
mineme0110
changed the title
bvoiturier
approved these changes
Feb 7, 2024
atala-dev
added a commit
that referenced
this pull request
Feb 7, 2024
## [1.78.0](v1.77.0...v1.78.0) (2024-02-07) ### 🚀 New Content * ensure qsg works 1.19.1 ([#77](#77)) ([a2f426f](a2f426f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.