Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser-stream): Add CJS build #716

Merged
merged 1 commit into from
Nov 16, 2022
Merged

feat(parser-stream): Add CJS build #716

merged 1 commit into from
Nov 16, 2022

Conversation

fb55
Copy link
Collaborator

@fb55 fb55 commented Oct 30, 2022

I want to use the parser stream in Cheerio, and am blocked by the current ESM nature of the module. The path of least resistance is to add a CJS build for the parser stream.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.251% when pulling 51893db on parser-stream-cjs into e6f304c on master.

@fb55 fb55 merged commit 254a250 into master Nov 16, 2022
@fb55 fb55 deleted the parser-stream-cjs branch November 16, 2022 14:12
@fb55
Copy link
Collaborator Author

fb55 commented Nov 16, 2022

Going ahead with this as it doesn't seem incredibly controversial, and I haven't heard anything in two weeks.

@fb55 fb55 mentioned this pull request Nov 16, 2022
jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants