Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Docs not consistent #110

Closed
ghost opened this issue Jan 4, 2019 · 5 comments
Closed

API Docs not consistent #110

ghost opened this issue Jan 4, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 4, 2019

The Readme.md for grade has:

dependencies {
compile 'com.stellarstation.api:stellarstation-api:0.2.0'
}

whereas the java demo for gradle has:

dependencies {
compile 'com.google.auth:google-auth-library-oauth2-http:0.9.1'
compile 'com.stellarstation.api:stellarstation-api:0.0.8'
['auth', 'netty', 'protobuf', 'stub'].each {
compile "io.grpc:grpc-$it:1.16.1"
}
compile 'io.netty:netty-tcnative-boringssl-static:2.0.17.Final'
compile 'org.slf4j:slf4j-simple:1.7.25'
}

to use with the fake server from git I had to use this in maven to get the PrintingClient
going:



com.stellarstation.api
stellarstation-api
0.0.6


com.google.auth
google-auth-library-oauth2-http
0.12.0


junit
junit
4.11
test


org.slf4j
slf4j-api
1.7.5


org.slf4j
slf4j-simple
1.6.4


io.grpc
grpc-auth
1.17.1


io.grpc
grpc-netty
1.17.1


com.google.protobuf
protobuf-java
3.5.1


My java client:

PrintingClientMain.java.txt

@anuraaga
Copy link
Contributor

anuraaga commented Jan 4, 2019

Thanks for reporting! Indeed the example code is using old versions of the API before we fixed to preserving compatibility which might be causing issues. We'll update the code, and make sure to update before releasing new versions.

To confirm what's happening, could you post any log of the problem you were having?

@ghost
Copy link
Author

ghost commented Jan 4, 2019

The usual maven dependencies :-)
gprc, protobuf & oauth2
I would have to revert back several days to start from the vanilla source :-(

@ghost
Copy link
Author

ghost commented Jan 4, 2019

My example code written in Java / Maven

but getting proto buff errors should I change the version?

WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.google.protobuf.UnsafeUtil (file:/Users/davidjohnson/.m2/repository/com/google/protobuf/protobuf-java/3.5.1/protobuf-java-3.5.1.jar) to field java.nio.Buffer.address WARNING: Please consider reporting this to the maintainers of com.google.protobuf.UnsafeUtil WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release 1280 [grpc-default-executor-1] INFO com.badgersoft.infostellarclient.PrintingClientMain - Got response: /Fd9vGhlBiI5TIWQDOlf5RALYH8qAXfiRJzgEHYPy2p748Ld27EW44zTZMhAmU6gYRPg4u83T046V8LIY+5mGpcCCuoIZRuF4JPw 1281 [grpc-default-executor-1] INFO com.badgersoft.infostellarclient.PrintingClientMain - Got response: YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh 1281 [grpc-default-executor-1] INFO com.badgersoft.infostellarclient.PrintingClientMain - Got response: YmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJi 1281 [grpc-default-executor-1] INFO com.badgersoft.infostellarclient.PrintingClientMain - Got response: Y2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2Nj

javaclient.zip

Dave

@ghost
Copy link
Author

ghost commented Jan 4, 2019

May be worth mentioning this when quoting the maven dependency for version 0.2.0

<repositories>
 ......
  <repository>
    <id>jcenter</id>
    <url>https://jcenter.bintray.com/</url>
  </repository>
  ......
</repositories>

@anuraaga
Copy link
Contributor

anuraaga commented Jan 5, 2019

Thanks for all the debugging - it was a release process mistake that I forgot to sync to maven central, which I just did. So you don't need to add jcenter as a repo anymore. I filed #111 to automate the step properly.

The protobuf warning happens on Java 9+ and is harmless. Presumably protobuf will finally fix that before Java follows through with their plan ;)

@ghost ghost closed this as completed Jan 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant