Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tendermint config #897

Merged

Conversation

tzemanovic
Copy link
Contributor

@tzemanovic tzemanovic commented Jun 9, 2021

closes #896

Hello, I'm trying to use the config module with Tendermint v0.34.x and I found that lots of the options have been changed. I've updated them to be in line with https://github.com/tendermint/tendermint/blob/v0.34.10/config/toml.go.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@tzemanovic tzemanovic marked this pull request as draft June 9, 2021 09:50
@tzemanovic tzemanovic marked this pull request as ready for review June 9, 2021 10:36
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #897 (83d2824) into master (5475e95) will decrease coverage by 0.0%.
The diff coverage is 57.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #897     +/-   ##
========================================
- Coverage    69.8%   69.7%   -0.1%     
========================================
  Files         200     200             
  Lines       16320   16311      -9     
========================================
- Hits        11393   11380     -13     
- Misses       4927    4931      +4     
Impacted Files Coverage Δ
tendermint/src/config.rs 60.6% <56.2%> (-1.2%) ⬇️
tendermint/tests/config.rs 97.2% <100.0%> (-0.7%) ⬇️
tendermint/src/abci/tag.rs 74.0% <0.0%> (-11.2%) ⬇️
tendermint/src/public_key.rs 59.7% <0.0%> (-1.6%) ⬇️
light-client/src/types.rs 29.8% <0.0%> (-0.6%) ⬇️
tendermint/src/node.rs 65.9% <0.0%> (ø)
light-client/src/macros.rs 10.4% <0.0%> (+<0.1%) ⬆️
tendermint/src/hash.rs 36.5% <0.0%> (+0.3%) ⬆️
rpc/src/endpoint/validators.rs 50.0% <0.0%> (+30.0%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5475e95...83d2824. Read the comment docs.

@tzemanovic tzemanovic marked this pull request as draft June 9, 2021 11:11
@tzemanovic tzemanovic marked this pull request as ready for review June 9, 2021 11:22
tarcieri
tarcieri previously approved these changes Jun 9, 2021
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks very much! 🎉 🙏 Just one minor request regarding the changelog.

CHANGELOG.md Outdated
@@ -4,6 +4,7 @@

- `[tendermint-abci,tendermint-rpc]` Fix DeliverTx response deserialization
issues with `gas_wanted` and `gas_used` fields ([#876])
- `[tendermint]` Update TendermintConfig for Tendermint v.0.34.x ([#896])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this entry as a separate file in the .changelog/unreleased/bug-fixes folder.

See https://github.com/informalsystems/tendermint-rs/blob/master/CONTRIBUTING.md#changelog for details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you too,unclog looks very handy for this!

Just a note, the format shown in CONTRIBUTING shows - [pkg] \#xxx Some description about the change, but the other entries in .changelog had a slightly different format, so I followed that for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll update that in the contributing guidelines 👍

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! 🙏

@thanethomson thanethomson merged commit 258a912 into informalsystems:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tendermint config is outdated
4 participants