Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-client: improve LightStore API #428

Open
romac opened this issue Jul 9, 2020 · 3 comments
Open

light-client: improve LightStore API #428

romac opened this issue Jul 9, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed light-client Issues/features which involve the light client

Comments

@romac
Copy link
Member

romac commented Jul 9, 2020

The current LightStore API is a bit underpowered, and forces us to implement ad-hoc method like get_non_failed or latest_trusted_or_verified to keep the downstream code clean.

It would be nice to have a slightly more powerful, perhaps query-based, API that would remove the need for such ad-hoc methods.

Additionally, the sled-based light store should be guarded under a feature flag, in order to plan for potential other databases or just help downstream dependencies avoid the dependency on sled if they don't need it.

@romac romac added enhancement New feature or request light-client Issues/features which involve the light client labels Jul 9, 2020
@romac
Copy link
Member Author

romac commented Jul 10, 2020

Something else to keep in mind and think hard about when designing the new API/abstraction:

@xla: Generally what I think we see here is that we let the actual domain of block storage creep into our higher level abstractions, which is informed too much by the key/value store semantics and it's physicality. — #419 (comment)

@xla
Copy link
Contributor

xla commented Jul 10, 2020

Maybe a broader look at the LightStore would include hiding/reducing the dependency on Sled, ie. #430 (comment)

@xla xla mentioned this issue Jul 10, 2020
5 tasks
@romac romac added the help wanted Extra attention is needed label Jul 10, 2020
@romac romac changed the title Improve LightStore API to remove need for ad-hoc methods Improve LightStore API Jul 10, 2020
@xla xla changed the title Improve LightStore API light-client: improve LightStore API Jul 10, 2020
@romac
Copy link
Member Author

romac commented Jul 16, 2020

We should also keep #449 (comment) in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed light-client Issues/features which involve the light client
Projects
None yet
Development

No branches or pull requests

2 participants