Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switch to Github Actions? #135

Closed
liamsi opened this issue Jan 29, 2020 · 8 comments · Fixed by #144
Closed

CI: switch to Github Actions? #135

liamsi opened this issue Jan 29, 2020 · 8 comments · Fixed by #144

Comments

@liamsi
Copy link
Member

liamsi commented Jan 29, 2020

Github Actions is an alternative to circleci. It looks worth exploring! Things like code coverage and uploading to codecov.io looks much simpler for instance (it's a bit like circleci's orbs but integrated into github; also the snippets are hosted here on this platform)

Discussion started here:
#134 (comment)

@liamsi liamsi changed the title Switch to Github Actions? CI: switch to Github Actions? Jan 29, 2020
@tac0turtle
Copy link
Contributor

@ebuchman @xla what you are thoughts on this? If people are up for the change, I'd love to make a contribution to the project.

@tarcieri
Copy link
Contributor

tarcieri commented Feb 3, 2020

I’ve moved most of my projects over. The UX is much better, and actions-rs is great

@liamsi
Copy link
Member Author

liamsi commented Feb 3, 2020

@marbar3778 at least I don't see a reason not to open a PR. I think it will also clarify a few things (e.g. performance, configurability) and make the discussion less abstract. If you are OK with a low probability that we might still stick with circle in the near future.

@tarcieri
Copy link
Contributor

tarcieri commented Feb 3, 2020

@marbar3778 make sure to check out https://github.com/actions-rs if you haven't already seen it

@tac0turtle
Copy link
Contributor

I have a branch here: tac0turtle#1 just need to figure out the codecov part but everything else looks good. Once its fixed ill open the PR against this repo

@liamsi
Copy link
Member Author

liamsi commented Feb 5, 2020

Awesome! The codecov part looks seemingly easy with this: https://github.com/marketplace/actions/rust-grcov
although, as always the devil is (or might be) in the details: actions-rs/grcov#3
The good thing about GA is that one can read through the code and understand what is going on in the background (in this case TypeScript)

@tarcieri
Copy link
Contributor

tarcieri commented Feb 5, 2020

grcov + codecov works fine

@greg-szabo
Copy link
Member

Awesome work Marko, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants