tendermint: Constant time hash equality #1094
Labels
domain-types
Anything relating to the creation, modification or removal of domain types
enhancement
New feature or request
security
Version(s) of tendermint-rs:
master
, v0.23.xDescription
At present we have two
Hash
types in tendermint-rs: one in thetendermint-rpc
crate inabci::transaction::Hash
and one in thetendermint
crate in thehash
module.I'm currently (in #1092) looking at removing the one in the
tendermint-rpc
crate and replacing it with the one from thetendermint
crate to deduplicate this domain type. The one in thetendermint-rpc
crate, however, implementssubtle::ConstantTimeEq
and the one intendermint
doesn't.Perhaps @tony-iqlusion or @hdevalence would like to weigh in here, but I'd think that it'd be important to implement
subtle::ConstantTimeEq
for thetendermint::hash::Hash
struct. The fact that we don't implement it fortendermint::hash::Hash
may actually be a problem (part of the reason I raised this issue simply being for awareness).Definition of "done"
When
tendermint::hash::Hash
implementssubtle::ConstantTimeEq
.The text was updated successfully, but these errors were encountered: