encode_vec() isn't infallible

[hu55a1n1]

What went wrong?

tendermint_proto::Protobuf::encode_vec() cannot fail since it uses a vector with required capacity and calls prost::Message::encode() which only fails if the input buffer doesn't have sufficient capacity.

fn encode_vec(&self) -> Result<Vec<u8>, Error> {
    let mut wire = Vec::with_capacity(self.encoded_len());
    self.encode(&mut wire).map(|_| wire)
}

Definition of "done"

tendermint_proto::Protobuf::encode_vec() could simply return a Vec<u8> and unwrap() internally.

fn encode_vec(&self) -> Vec<u8> {
    let mut wire = Vec::with_capacity(self.encoded_len());
    self.encode(&mut wire).map(|_| wire).unwrap()
}

[tony-iqlusion]

Nit:

self.encode(&mut wire).map(|_| wire).unwrap()

It would be better to use expect:

self.encode(&mut wire).map(|_| wire).expect("buffer size too small")

This clearly states the expected invariant from prost::Message::encode, and using expect over unwrap is generally considered a Rust best practice.

[thanethomson]

@hu55a1n1 are you still going to handle this? I can take over if you don't have time for it.

[hu55a1n1]

Sorry for the delay in getting to this @thanethomson. I started working on this before but got busy with other things. Just opened PR #1093 to resolve this. 👍