Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip config processing for the completions command #1822

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Skip config processing for the completions command #1822

merged 2 commits into from
Jan 31, 2022

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Jan 28, 2022 •
edited
Loading

Description

The completions command does not need the relayer configuration
to be processed.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@mzabaluev mzabaluev added I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Jan 28, 2022
@mzabaluev mzabaluev marked this pull request as ready for review January 28, 2022 16:40
@romac romac merged commit f3f17ca into master Jan 31, 2022
@romac romac deleted the mikhail/skip-config-for-completions branch January 31, 2022 09:42
@romac romac added this to the v0.11.1 milestone Feb 2, 2022
michaelfig pushed a commit to agoric-labs/ibc-rs that referenced this pull request Feb 4, 2022
@mzabaluev @michaelfig
Skip config processing for the completions command (informalsystems#1822
c46501b 
)

* Skip config processing for the completions command

* Changelog entry for informalsystems#1822
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@mzabaluev
Skip config processing for the completions command (informalsystems#1822
ab5ddc5 
)

* Skip config processing for the completions command

* Changelog entry for informalsystems#1822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mzabaluev @romac