Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-keys keyring and option to override the signing key when sending packets with ft-transfer #963

Closed
5 tasks
romac opened this issue May 20, 2021 · 0 comments · Fixed by #962
Closed
5 tasks
Assignees
Labels
I: CLI Internal: related to the relayer's CLI
Milestone

Comments

@romac
Copy link
Member

romac commented May 20, 2021

Crate

relayer, relayer-cli

Summary

  • Add support for multiple keys to the keyring.
  • Add a option to the tx raw ft-transfer command to override the signing key used for sending messages.

Problem Definition

When sending large amounts of packets with ft-transfer, we encounter a sequence mismatch because the supervisor sends txes while the ft-transfer command is still running. By using a different account when sending packets, the supervisor and the transfer command will get different sequence numbers and therefore won't step on each other's toes.

Acceptance Criteria

The keyring can holds multiple keys and ft-transfer command can be used to send large amount of packets without encountering a sequence mismatch error.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the I: CLI Internal: related to the relayer's CLI label May 20, 2021
@romac romac added this to the 05.2021 milestone May 20, 2021
@romac romac self-assigned this May 20, 2021
romac added a commit that referenced this issue May 21, 2021
Closes: #963

## Description

- [x] Add support for multiple keys to the keyring
- [x] Update the `dev-env` script:
  - [x] Create a new `user2` account on top of the existing `user` account
  - [x] Add this new account to the Hermes keyring under the key name `user2`
  - [x] The key for the default `user` account is added with the default `key_name` specified in the config
- [x] Add a `--key` option to the `tx raw ft-transfer` command to override the default `key_name` used for sending messages

## Commits

* Support for multiple keys in the keyring

* Update keys add, restore and list commands

* Update scripts and add both a `user` and `hermes` account

* Add a `--key` option to `tx raw ft-transfer` to override the signing key to use for the transfer

* Use ft-transfer --key option in e2e test suite

* Better errors when key file cannot be found

* Fix typo

* Update changelog

* Add second user account on CI

* Rename second user account to user2

* Do not use multi-keys on CI
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
…malsystems#962)

Closes: informalsystems#963

## Description

- [x] Add support for multiple keys to the keyring
- [x] Update the `dev-env` script:
  - [x] Create a new `user2` account on top of the existing `user` account
  - [x] Add this new account to the Hermes keyring under the key name `user2`
  - [x] The key for the default `user` account is added with the default `key_name` specified in the config
- [x] Add a `--key` option to the `tx raw ft-transfer` command to override the default `key_name` used for sending messages

## Commits

* Support for multiple keys in the keyring

* Update keys add, restore and list commands

* Update scripts and add both a `user` and `hermes` account

* Add a `--key` option to `tx raw ft-transfer` to override the signing key to use for the transfer

* Use ft-transfer --key option in e2e test suite

* Better errors when key file cannot be found

* Fix typo

* Update changelog

* Add second user account on CI

* Rename second user account to user2

* Do not use multi-keys on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant