Hermes query commands return success despite mismatching arguments

[adizere]

Thanks to Jeseon Lee for surfacing this bug during relayer testing.

Crate

ibc-relayer-cli and ibc-relayer

Summary of Bug

Some query sub-commands for a given chain return success code even if querying for a channel that does not exist on the specified chain.

Version

0.2.0

Steps to Reproduce

./scripts/dev-env ~/.hermes/config.toml ibc-0 ibc-1 ibc-2

# This command creates a channel with identifier `channel-0` on
# both ends
hermes create channel ibc-0 ibc-1 --port-a transfer --port-b transfer

# This command creates a channel with identifier `channel-1` on
# chain ibc-0, and identifer `channel-0` on ibc-2
hermes create channel ibc-0 ibc-2 --port-a transfer --port-b transfer

# Query for unreceived-packets for destination chain `ibc-2`
# If we specify `channel-1`, the query should return error, since this channel
# provides a bath to destination chain `ibc-1` (not `ibc-2`).
hermes help query packet unreceived-packets ibc-2 ibc-0 transfer channel-1

> Success: []

The same problem appears for the unreceived-acks sub-command.

Acceptance Criteria

An error should be returned in case of mismatching arguments to query unreceived-packets or unreceived-acks.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned