Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc-proto version bump #682

Closed
5 tasks
adizere opened this issue Feb 18, 2021 · 0 comments · Fixed by #683
Closed
5 tasks

ibc-proto version bump #682

adizere opened this issue Feb 18, 2021 · 0 comments · Fixed by #683
Labels
I: dependencies Internal: related to dependencies
Milestone

Comments

@adizere
Copy link
Member

adizere commented Feb 18, 2021

Crate

ibc-proto

Summary of Bug

Context: Attempting to publish on crates.io the newest version of crate ibc, v0.1.1. We wanted to minimize the number of crates which go through this minor release, so decided not to bump the version ibc-proto and let this one sit at its current version 0.7.0.

Problem: Not possible to release ibc without bumping the version of crate ibc-proto. This is because both ibc and ibc-proto depend on tendermint-proto, which was updated to 0.18.1 in ibc.

The precise error is:

Attempting dry run of publishing crate ibc...
    Updating crates.io index
   Packaging ibc v0.1.1 (/Users/adi/Hammers/ibc-rs/modules)
   Verifying ibc v0.1.1 (/Users/adi/Hammers/ibc-rs/modules)
error: failed to verify package tarball
Caused by:
  failed to select a version for `tendermint-proto`.
      ... required by package `ibc-proto v0.7.0`
      ... which is depended on by `ibc v0.1.1 (/Users/adi/Hammers/ibc-rs/target/package/ibc-0.1.1)`
  versions that meet the requirements `=0.18.0` are: 0.18.0

Consolidation of ibc-proto

The present issue raises a question: whether we shouldn't consider moving domain types and their implementation altogether into crate ibc-proto. This question may be tackled with https://github.com/informalsystems/ibc-rs/issues/425.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the v0.1.1 milestone Feb 18, 2021
@adizere adizere added the I: dependencies Internal: related to dependencies label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant