Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent identifier handling across client, connections and channels #91

Closed
3 of 5 tasks
ancazamfir opened this issue Feb 8, 2021 · 0 comments
Closed
3 of 5 tasks

Consistent identifier handling across client, connections and channels #91

ancazamfir opened this issue Feb 8, 2021 · 0 comments
Assignees
@adizere

Comments

@ancazamfir
Copy link
Collaborator

Crate

modules

Summary

process() function in connection and channel handlers should follow the same approach as the one in client wrt identifier allocation, i.e. the process() function should return an ID that is later stored by the keeper that also increments the next identifier to be available for next handler calls.

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir mentioned this issue Feb 8, 2021
Merged
5 tasks
@romac romac changed the title consistent identifier handling across client, connections and channels Consistent identifier handling across client, connections and channels Feb 9, 2021
@adizere adizere self-assigned this Feb 9, 2021
@adizere adizere mentioned this issue Feb 10, 2021
Merged
5 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
hu55a1n1 pushed a commit that referenced this issue Sep 29, 2022
@adizere
Validation for ICS7 ClientState::new(). (#111)
95f5f24 
* (#91) WIP: Added validation for ICS7 ClientState::new().

* Bit more progress on validation for ICS7 ClientState::new()

* Initialization for dummy header done. Tests done.

* Added the JSON representation of a dummy signed header.
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@adizere
Validation for ICS7 ClientState::new(). (cosmos#111)
d46cba2 
* (cosmos#91) WIP: Added validation for ICS7 ClientState::new().

* Bit more progress on validation for ICS7 ClientState::new()

* Initialization for dummy header done. Tests done.

* Added the JSON representation of a dummy signed header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adizere @ancazamfir