Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CLI parameters and chain queries #572

Closed
5 tasks done
ancazamfir opened this issue Jan 28, 2021 · 0 comments · Fixed by #644
Closed
5 tasks done

Cleanup CLI parameters and chain queries #572

ancazamfir opened this issue Jan 28, 2021 · 0 comments · Fixed by #644
Assignees
@ancazamfir
Labels
O: code-hygiene Objective: cause to improve code hygiene
Milestone
02.2021

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Jan 28, 2021 •
edited
Loading

Crate

relayer, relayer-cli

Summary of Bug

Some CLIs have String for ID instead of typed ID. We should review all CLIs and change to typed IDs and make them required where that is the case.

Some CLIs are still using the chain.query() from the era before gRPC, they should used the specific queries instead.

Version

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added the O: code-hygiene Objective: cause to improve code hygiene label Jan 28, 2021
@ancazamfir ancazamfir added this to the v0.1.1 milestone Jan 28, 2021
This was referenced Jan 28, 2021
Merged
Closed
@ancazamfir ancazamfir self-assigned this Feb 12, 2021
@ancazamfir ancazamfir changed the title All CLIs should have typed parameters Cleanup CLI parameters and chain queries Feb 12, 2021
@ancazamfir ancazamfir mentioned this issue Feb 12, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancazamfir ancazamfir

Labels
O: code-hygiene Objective: cause to improve code hygiene
Projects
None yet
Milestone
02.2021
Development

Successfully merging a pull request may close this issue.

Cleanup CLIs, query usage and chains informalsystems/hermes
1 participant
@ancazamfir