Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for chains that don't have "cosmos" as hrp for bech32 address #416

Closed
5 tasks
andynog opened this issue Nov 24, 2020 · 2 comments
Closed
5 tasks
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@andynog
Copy link
Contributor

andynog commented Nov 24, 2020

Crate

modules

Summary of Bug

Currently, if one of the chains configure on the relayer doesn't have an address starting with "cosmos" , the transactions will fail with a

conn init failed, error:  tx error: GRPC error: GRPC error: status: Unknown, message: "invalid Bech32 prefix; expected akash, got cosmos", details: [], metadata: MetadataMap { headers: {} }

I think this might have to do with this code since "cosmos" is hard-coded there https://github.com/informalsystems/ibc-rs/blob/db04e2468adc09551563b09cf137c872ba800df3/modules/src/address.rs#L11

Version

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@andynog andynog added the A: bug Admin: something isn't working label Nov 24, 2020
@ancazamfir ancazamfir changed the title Support for chains that doesn't have "cosmos" as hrp for bech32 address Support for chains that don't have "cosmos" as hrp for bech32 address Dec 23, 2020
@adizere
Copy link
Member

adizere commented Feb 15, 2021

Closing in favor of cosmos/ibc-rs#88.

@romac
Copy link
Member

romac commented Mar 24, 2021

Fixed in #753

@romac romac closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants