-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate protos between ibc-rs and tendermint-rs #284
Comments
This is blocking progress for #277 where I get errors like: ^^^^ the trait I would expect at most something like: |
The problem is that the Cosmos SDK is copying Tendermint messages from the Tendermint repository's protobuf message folder. Because we compile the messages separately in Prost, the IBC Prost compiler doesn't know about a separate set of messages in the Tendermint repository and compiles them as it sees them. We have to figure out if we can merge the two protobuf message folders together either at the source or during compilation into Rust structs. Or as a third option, somehow separate the Tendermint-related messages in the Cosmos SDK. |
#292 solves the problem but it requires a rebuild of the IBC protobuf files. |
Summary of Bug
Some IBC proto files (e.g.
ibc.tendermint.rs::Header
) need to reference some other proto files and structures (e.g.tendermint.types.rs::SignedHeader
ortendermint.types.rs::ValidatorSet
) that belong to tendermint-rs where we expect the conversions between raw and domain types are implemented.Presently the ibc-proto files point to duplicate tendermint files in ibc-proto, in particular
tendermint.types.rs
for the examples above. But I believe alltendermint
files in IBC proto are dups of the ones intendermint-rs
Version
master
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: