Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICS07] Incorrect ConsensusState storage for headers with heights lower than ClientState height #1080

Closed
Farhad-Shabani opened this issue Feb 8, 2024 · 0 comments · Fixed by #1081
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Bug Summary

Reported by @vmarkushin

When a header with a height lower than the current client height is submitted for the first time, we store the consensus state at the height of the current client state instead of the provided header height. This action overwrites the existing consensus state for the current height. Since the header is from the past, a ConsensusState with an older root is installed at that path. This disrupts commitment proof verification, as the provided proof will be for a different state root than the one we actually stored.

Details

  • [H] Installed headers
  • (H) Unseen headers

---- [5] ---- [7] -- (8) ---- [10] -------------- (20)

Scenario: Submit a header with height 8 and the trusted height of 7

Version

=< v0.50.0

@Farhad-Shabani Farhad-Shabani added the A: bug Admin: something isn't working label Feb 8, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 8, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 8, 2024
@Farhad-Shabani Farhad-Shabani self-assigned this Feb 8, 2024
@Farhad-Shabani Farhad-Shabani changed the title [ICS07] Incorrect ConsensusState storage for headers with heights lower than trusted height [ICS07] Incorrect ConsensusState storage for headers with heights lower than ClientState height Feb 8, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Feb 9, 2024
@McDaan McDaan mentioned this issue May 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant