Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hermes default should be pretty-printing instead of JSON #805

Closed
5 tasks done
adizere opened this issue Apr 7, 2021 · 0 comments · Fixed by #796
Closed
5 tasks done

Hermes default should be pretty-printing instead of JSON #805

adizere opened this issue Apr 7, 2021 · 0 comments · Fixed by #796
Assignees
@adizere
Labels
O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone
03.2021

Comments

@adizere
Copy link
Member

adizere commented Apr 7, 2021 •
edited
Loading

Crate

ibc-relayer-cli

Summary

Currently Hermes provides all output in JSON format. We'd like to enable by default human-readable format, while still permitting to switch to JSON in case this is necessary for certain use-cases.

These requirements are informed inspired both from ADR 006, as well as other issues (#628, #730).

Proposal

Introduce the global -j / --json flag to signal to Hermes that JSON should be used for all output. If this flag is not specified, then output is human readable (pretty printing).

Acceptance Criteria

  • end-to-end tests work with the -j flag
  • all CLIs by default output in human readable

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added the O: usability Objective: cause to improve the user experience (UX) and ease using the product label Apr 7, 2021
@adizere adizere added this to the 03.2021 milestone Apr 7, 2021
@adizere adizere self-assigned this Apr 7, 2021
@adizere adizere mentioned this issue Apr 7, 2021
Merged
5 tasks
@romac romac closed this as completed in #796 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Milestone
03.2021
Development

Successfully merging a pull request may close this issue.

Hermes: replace default JSON with human-readable output informalsystems/hermes
1 participant
@adizere