Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing packet data monitoring #4298

Open
5 tasks
ljoss17 opened this issue Feb 12, 2025 · 0 comments
Open
5 tasks

Improve missing packet data monitoring #4298

ljoss17 opened this issue Feb 12, 2025 · 0 comments

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Feb 12, 2025

Summary

Hermes currently logs warnings when it fails to query the packet data needed to relay a transaction. However, these warnings can be misleading—for instance, if packet clearing happens simultaneously, one worker might fail to retrieve the data and produce an inaccurate warning. Logs can also be easily overlooked, indicating the need for a more persistent approach.

Proposal

Adding metrics

Introduce a new metric that tracks packet data queries which fail repeatedly or over a prolonged period. This would help distinguish transient errors—such as when a packet is relayed during the query—from genuine, long-standing issues that require attention.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant