Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding peer_id, height and hash in light add command #428

Closed
5 tasks done
romac opened this issue Dec 1, 2020 · 0 comments · Fixed by #429
Closed
5 tasks done

Allow overriding peer_id, height and hash in light add command #428

romac opened this issue Dec 1, 2020 · 0 comments · Fixed by #429
Assignees
Labels
I: CLI Internal: related to the relayer's CLI
Milestone

Comments

@romac
Copy link
Member

romac commented Dec 1, 2020

Crate

relayer-cli

Summary

Allow overriding peer_id, height and hash in light add command.

Problem Definition

During testing, we often need to add both a primary and witness which point to the same node.
Those will thus get the same peer id, causing the light add command to rightfully prevent us from adding the second one.
We can work around this by updating the configuration file manually, but that's quite cumbersome.
We therefore need a way to override the peer id from the command line (and while we are it the height and hash as well).

Proposal

Add options to the light add command to override the fetched peer id, height and hash.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the I: CLI Internal: related to the relayer's CLI label Dec 1, 2020
@romac romac added this to the v0.0.6 milestone Dec 1, 2020
@romac romac self-assigned this Dec 1, 2020
@romac romac closed this as completed in #429 Dec 1, 2020
@adizere adizere modified the milestones: v0.0.6, v0.0.5 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants