Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on overflow in release mode #3390

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Panic on overflow in release mode #3390

merged 4 commits into from
Jun 5, 2023

Conversation

romac
Copy link
Member

@romac romac commented Jun 5, 2023 •
edited
Loading

Closes: #3392

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac marked this pull request as ready for review June 5, 2023 11:36
@romac romac merged commit a9335b3 into master Jun 5, 2023
@romac romac deleted the romac/enable-overflow-checks branch June 5, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hermes should panic on overflow
1 participant
@romac