Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --debug global flag #2852

Closed
2 of 5 tasks
romac opened this issue Nov 10, 2022 · 0 comments · Fixed by #3352
Closed
2 of 5 tasks

Add --debug global flag #2852

romac opened this issue Nov 10, 2022 · 0 comments · Fixed by #3352
Assignees
Labels
A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: rpc Internal: related to (g)RPC O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@romac
Copy link
Member

romac commented Nov 10, 2022

Summary

Add a --debug flag which can either be be repeated (--debug=rpc --debug=profiling) or take a comma-separated list of sections to enable debugging for (--debug=rpc,profiling), or a combination of the two.

The former is easier to use when invoking Hermes from scripts etc, while the latter is shorted to type when invoked manually.

rpc

Passing --debug=rpc to Hermes has the effect of printing out the outgoing and incoming RPC requests, having the same effect as setting tendermint_rpc=debug to the tracing filter.

profiling

Passing --debug=profiling to Hermes which enables the profiling output.

Problem Definition

It's easier to instruct users to add a flag to their Hermes command rather than ask them to set an esoteric variable to a cryptic value.

Proposal

As above.

Acceptance Criteria

Hermes can take a global --debug flag which can take the rpc value and print out the incoming and outgoing RPC requests.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added O: new-feature Objective: cause to add a new feature or support A: good-first-issue Admin: good for newcomers O: usability Objective: cause to improve the user experience (UX) and ease using the product I: rpc Internal: related to (g)RPC A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Nov 10, 2022
@romac romac changed the title Add --debug=rpc global flag Add --debug=DEBUG_SECTION global flag May 22, 2023
@romac romac self-assigned this May 22, 2023
@romac romac added this to the v1.5 milestone May 22, 2023
@romac romac changed the title Add --debug=DEBUG_SECTION global flag Add --debug global flag May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: rpc Internal: related to (g)RPC O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant