Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a min_gas_price verification step in the health check process #2776

Closed
5 of 7 tasks
seanchen1991 opened this issue Oct 27, 2022 · 0 comments · Fixed by #2873
Closed
5 of 7 tasks

Add a min_gas_price verification step in the health check process #2776

seanchen1991 opened this issue Oct 27, 2022 · 0 comments · Fixed by #2873
Assignees
Labels
I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Oct 27, 2022

Summary

Add a min_gas_price verification step in the health check process.

Problem Definition

We often ask users to provide us with the min_gas_price value as part of their app.toml when debugging issues. Now that the SDK exposes this value over gRPC in v0.45.10, we can automatically check for this value as part of Hermes' health check process so that there wouldn't be a need to ask the user for this value directly.

Proposal

Add a min_gas_price verification step in the health check process that checks that the gas_price parameter in the Hermes config.toml file is set to be greater than or equal to the min_gas_price advertised by the chain.

This will require generating 0.46.4 IBC proto files in order to access the cosmos/base/node/v1beta1 gRPC endpoint in order to fetch the chain configuration.

Acceptance Criteria

  • Generate 0.46.4 IBC proto files
  • Added a min_gas_price verification step to the health check

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@seanchen1991 seanchen1991 self-assigned this Oct 27, 2022
@adizere adizere added this to the v1.2 milestone Oct 31, 2022
@adizere adizere added P-high I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants