Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChainEndpoint::query_next_sequence_receive() should include a height in no-proof case #2244

Closed
5 tasks
plafer opened this issue May 27, 2022 · 1 comment
Closed
5 tasks

ChainEndpoint::query_next_sequence_receive() should include a height in no-proof case #2244

plafer opened this issue May 27, 2022 · 1 comment

Comments

@plafer
Copy link
Contributor

plafer commented May 27, 2022

Summary of Bug

With the refactor of #2226, I realized that the without proof didn't specify a height, whereas the query with proof (formerly in proven_packet()) did. gRPC queries now support heights (#1088). We should remember to add the height in the gRPC request in ChainEndpoint::query_next_sequence_receive() when we address #1088.

Depends on: #2226
Related: #1088

v0.15.0

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac
Copy link
Member

romac commented Nov 9, 2023

Fixed in #3662

@romac romac closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romac @plafer