Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite simulation test to use estimate_tx_fees #2208

Open
5 tasks
soareschen opened this issue May 11, 2022 · 0 comments
Open
5 tasks

Rewrite simulation test to use estimate_tx_fees #2208

soareschen opened this issue May 11, 2022 · 0 comments
Labels
O: tests Objective: Test more aspect of the relayer

Comments

@soareschen
Copy link
Contributor

soareschen commented May 11, 2022

Summary

The manual test test_simulation should be rewritten into an automated test that calls estimate_tx_fees to assert the expected outcome.

Problem Definition

The original test_simulation was written as a manual test, as there was no easy way to capture the log output in tests.

With #2044 merged, we can test the behavior by calling functions such as estimate_tx_fees or send_tx_simulate directly. This will allow us to parse the result of the simulation directly, instead of observing it manually from the logs.

Other than that, we noticed that the logs when running the simulation test in Gaia v6 and v7 are different from the original expected behavior in Gaia v5. This should be investigated further, and tested in the new simulation test.

The error shown on Gaia v6 looks like:

2022-05-11T08:53:40.187410Z ERROR packet_cmd{src_chain=ibc-0-60730086 src_port=transfer src_channel=channel-5 dst_chain=ibc-1-1a10ac2d}: ibc_relay
er::worker::packet: will retry: schedule execution encountered error:
   0: failed with underlying error
   1: gRPC call failed with status: status: Unknown, message: "failed to execute message; message index: 0: receive packet verification failed: co
uldn't verify counterparty packet commitment: failed packet commitment verification for client (07-tendermint-2): client state height < proof heig
ht ({60730086 39} < {60730086 42}), please ensure the client has been updated: invalid height", details: [], metadata: MetadataMap { headers: {"co
ntent-type": "application/grpc", "x-cosmos-block-height": "38"} }

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@soareschen soareschen added the O: tests Objective: Test more aspect of the relayer label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: tests Objective: Test more aspect of the relayer
Projects
None yet
Development

No branches or pull requests

1 participant