Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes tx raw shows all the data bytes in a column #1559

Closed
6 tasks
mpoke opened this issue Nov 10, 2021 · 2 comments · Fixed by #1944
Closed
6 tasks

hermes tx raw shows all the data bytes in a column #1559

mpoke opened this issue Nov 10, 2021 · 2 comments · Fixed by #1944
Assignees
Labels
A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: CLI Internal: related to the relayer's CLI O: code-hygiene Objective: cause to improve code hygiene O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@mpoke
Copy link

mpoke commented Nov 10, 2021

Summary of Bug

hermes tx raw ft-transfer shows all the data bytes in a column, which makes it hard to look at the other attributes. It would be more appropriate to compact the bytes output.

The same issue is with all messages that contain data, e.g., packet-ack.

Version

v0.8.0

Steps to Reproduce

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@mpoke mpoke added I: CLI Internal: related to the relayer's CLI O: code-hygiene Objective: cause to improve code hygiene labels Nov 10, 2021
@romac romac changed the title hermes tx raw shows all the data bytes in a column hermes tx raw shows all the data bytes in a column Nov 10, 2021
@romac
Copy link
Member

romac commented Nov 10, 2021

Thanks for opening this issue! What output format would you think is most appropriate here? Byte vector on a single line, hex, base64, something else?

@mpoke
Copy link
Author

mpoke commented Nov 10, 2021

Thanks for opening this issue! What output format would you think is most appropriate here? Byte vector on a single line, hex, base64, something else?

I think a byte vector would be better. I guess since it's a tool for testing/dev it's useful to see the data bytes.

@adizere adizere added the A: good-first-issue Admin: good for newcomers label Nov 11, 2021
@adizere adizere added this to the v0.9.3 milestone Nov 11, 2021
@romac romac added the A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews label Nov 12, 2021
@adizere adizere modified the milestones: v0.11.1, v0.11.2 Jan 26, 2022
@adizere adizere modified the milestones: v0.12.0, v0.12.1 Feb 14, 2022
@adizere adizere added the O: usability Objective: cause to improve the user experience (UX) and ease using the product label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: CLI Internal: related to the relayer's CLI O: code-hygiene Objective: cause to improve code hygiene O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants