MsgWirePayForData messages are validate twice by the proposer

[mpoke]

MsgWirePayForData messages are validate twice by the proposer, once in CheckTx and once in PrepareProposal i.e., https://github.com/celestiaorg/celestia-app/blob/e088d61fcb6579b4bc797deefd2ceff7601aa079/app/parse_txs.go#L96.

[rootulp]

Naive question: are there negative consequences associated with calling ValidateBasic() twice? The second invocation appears only applicable to transactions that include a MsgWirePayForBlob. This may have been expensive prior to square size independent commitments but per #6 (comment) seems less expensive.

[mpoke]

Besides the extra computation, there is no negative consequence that I see.

[rootulp]

Thanks! I'm inclined to preserve the redundant ValidateBasic() invocation because the extra computation doesn't seem critical to remove. Please re-open if there's a compelling reason to remove the second ValidateBasic() invocation. @evan-forbes @mpoke

[evan-forbes]

Wait, I think it makes sense to remove the extra checks. That's what we're doing in the current refactor to get rid of the WirePFB

[evan-forbes]

You are correct that it is optional, though