Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit logic in TSM LastModified test #9333

Closed
joelegasse opened this issue Jan 17, 2018 · 0 comments · Fixed by #9464
Closed

Revisit logic in TSM LastModified test #9333

joelegasse opened this issue Jan 17, 2018 · 0 comments · Fixed by #9464
Assignees
@jwilder
Labels
area/storage difficulty/low Resolving this issue should take a day or two. skipped-tests

Comments

@joelegasse
Copy link
Contributor

As part of #9327, a test in the tsm1 package starting failing. It is being skipped for now, but we need to revisit the logic in that test to see if it makes sense, or if it was actually verifying the incorrect/accidental behavior of the old code.

The best part is that I can't get it to fail locally, and it only seems to fail in Circle.
@jwilder jwilder added the difficulty/low Resolving this issue should take a day or two. label Jan 30, 2018
@jwilder jwilder mentioned this issue Feb 20, 2018
Merged
6 tasks
@ghost ghost assigned jwilder Feb 20, 2018
@ghost ghost added the review label Feb 20, 2018
@ghost ghost removed the review label Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwilder jwilder

Labels
area/storage difficulty/low Resolving this issue should take a day or two. skipped-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-open last WAL segment influxdata/influxdb
2 participants
@jwilder @joelegasse