Gogoprotobuf removed ErrWrongType, which is depended on by Raft

[bmhatfield]

This change: https://code.google.com/p/gogoprotobuf/source/detail?r=6f3c1d67bdb9f8bd3662e6647348756dc1ccbde2

Breaks:

# github.com/influxdb/influxdb/_vendor/raft/protobuf
_vendor/raft/protobuf/append_entries_request.pb.go:113: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_request.pb.go:130: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_request.pb.go:147: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_request.pb.go:164: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_request.pb.go:181: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_request.pb.go:204: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_responses.pb.go:97: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_responses.pb.go:114: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_responses.pb.go:131: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_responses.pb.go:148: undefined: proto.ErrWrongType
_vendor/raft/protobuf/append_entries_responses.pb.go:148: too many errors

[bmhatfield]

I filed an issue on https://code.google.com/p/gogoprotobuf/issues/detail?id=23 - but honestly I am not sure how this is intended to be reconciled.

[otoolep]

I am hitting the same build issue this morning on Kubuntu 14.04, 64-bit. I am unable to build top-of-master.

[otoolep]

@pauldix @jvshahid -- are you guys running continuous builds anywhere, for any arch and distro? Perhaps I am missing something, but it's disappointing to checkout master and find it doesn't build. This isn't the first time it's happened (though I realise this is not strictly a build break in influxdb). :-(

[bmhatfield]

It appears that they are (https://travis-ci.org/influxdb/influxdb/builds) but they've been failing for 10d+.

From my notes on building this, these are the most recent buildable shas:

InfluxDB Buildable SHA: 22cb673
gogoprotobuf Buildable SHA: 192f37e (RE: Removed ErrWrongType)

[otoolep]

I started ignoring that CI build a long time ago, since it always seemed to be red, even when I could build. :-)

[jvshahid]

This is now fixed. I also took the chance to merge all changes from the upstream raft implementation which looks like it's still suffering from that error, but since we have the luxury of regenerating the protobuf file, I went ahead and updated our copy. The tests should also be fixed to be more robust and to reduce the intermittent failures we get on travis ci.

[otoolep]

Great, thanks @jvshahid, I am good now.

[otoolep]

@jvshahid -- are the directions to regenerate the protobuf files documented anywhere? I'd like to know how to do it. I studied the README in the gogoprotobuf package, but I still had no success.

[jvshahid]

@otoolep why are you trying to regenerate the gogoprotobuf files, these are checked in the repository ?

[otoolep]

Fair question. I would like to experiment with changing the protobuf spec from time-to-time. Perhaps this would be better for the maintainers of the raft repo (who need to fix their build anyway).