Limit series count in selection #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jwilder @jsternberg |
| @@ -463,6 +466,12 @@ func (e *QueryExecutor) executeSelectStatement(stmt *influxql.SelectStatement, c | |||
| em.OmitTime = stmt.OmitTime | |||
| defer em.Close() | |||
|
|
|||
| // Calculate initial stats across all iterators. | |||
There was a problem hiding this comment.
Should this be before creating the emitter?
There was a problem hiding this comment.
The emitter is handling the closing of the iterators so I didn't want to do a double defer close. Really, the iterators should close themselves but that's a change for a different PR.
|
I originally added the limit to This PR is a WIP because I need to know how we want to specify this parameter. I can think of two ways:
|
benbjohnson
force-pushed
the
limit-series
branch
from
0ece1f9 to
50e8856
Compare
|
Limit added to server configuration. |
This commit adds a buffer for stats to be updated without requiring a mutex lock/unlock on every point. The tradeoff is that stats are not exactly precise. This works for our use case because stats are only periodically checked.
This commit adds a configurable limit to the number of series that can be returned from a `SELECT` statement. The limit is checked immediately after planning and is determined by the use of iterator stats. Fixes influxdata#6076
benbjohnson
force-pushed
the
limit-series
branch
from
50e8856 to
a6d9930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds a configurable limit to the number of series that can be returned from a
SELECTstatement. The limit is checked immediately after planning and is determined by the use of iterator stats.Fixes #6076