Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum verification to TSM inspect tool #5502

Closed
jwilder opened this issue Feb 1, 2016 · 5 comments
Closed

Add checksum verification to TSM inspect tool #5502

jwilder opened this issue Feb 1, 2016 · 5 comments
Labels
Milestone

Comments

@jwilder
Copy link
Contributor

jwilder commented Feb 1, 2016

TSM files contain a checksum per block. The inspect_tsm tool should be updated to be able to verify and report any blocks that fail verification.

Original issue from #4977

@seiflotfy
Copy link
Contributor

I am working on this, these are my steps:

  • implement validate on block in tsm1 reader
  • expose to inspect_tool

@seiflotfy
Copy link
Contributor

What is the expected behaviour here? https://github.com/influxdata/influxdb/blob/master/tsdb/engine/tsm1/reader.go#L910
Return error?

@jwilder
Copy link
Contributor Author

jwilder commented Feb 5, 2016

@seiflotfy It should not validate there. That TODO and others can be removed. The influx_inspect tool should be able to report the issue.

@toddboom
Copy link
Contributor

toddboom commented Feb 5, 2016

Agreed. I think for now, the only goal is to have the tool run the verification. The database itself won't do any checksum enforcement yet.

@seiflotfy
Copy link
Contributor

OK on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants