Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL replay hangs if the response wasn't received #535

Merged
merged 1 commit into from
May 13, 2014
Merged

Conversation

jvshahid
Copy link
Contributor

The way the WAL works is by sequentially and synchronously sending write requests to other nodes using ClusterServer.MakeRequest. MakeRequest is inherently problematic, since it will block indefinitely waiting for the response, if the response wasn't received MakeRequest will never return. In the case of the WAL, that means replication will stop completely until the server is bounced.

@jvshahid jvshahid added this to the 0.6.3 milestone May 12, 2014
@jvshahid jvshahid modified the milestones: Next release, 0.6.3 May 13, 2014
@jvshahid jvshahid assigned jvshahid and unassigned errplane-pilots May 13, 2014
@pauldix
Copy link
Member

pauldix commented May 13, 2014

lgtm

pauldix added a commit that referenced this pull request May 13, 2014
WAL replay hangs if the response wasn't received
@pauldix pauldix merged commit 730d4d4 into master May 13, 2014
@jvshahid jvshahid deleted the fix-535-wal-hang branch May 13, 2014 19:43
jvshahid added a commit that referenced this pull request May 27, 2014
@jvshahid jvshahid removed their assignment Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants