Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

409 is a better error code IMNSHO #483

Closed
wants to merge 2 commits into from

Conversation

freeformz
Copy link

This also allows a client to check the error code instead of the text.

This also allows a client to check the error code instead of the text.
@jvshahid
Copy link
Contributor

@freeformz I don't think the change will do the right thing. errorToStatusCode actually checks for different error conditions and set the status code to the appropriate value. For example a non admin user can't create databases and will get a 403 in this case. If you want to add another value, it should go in errorToStatusCode

@freeformz
Copy link
Author

That makes sense. I'll update that function instead.

@freeformz
Copy link
Author

@jvshahid Better? I would have written an integration test, but I'm still figuring out the tests and system and stuff.

jvshahid added a commit that referenced this pull request May 2, 2014
@jvshahid jvshahid closed this in d054713 May 2, 2014
jvshahid added a commit that referenced this pull request May 27, 2014
pauldix pushed a commit that referenced this pull request May 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants