Merge same-series data if not chunking #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
changed the title
If no chunking was requested by the user, the co-ordinating node buffers all results in RAM before emitting a single result. However buffering was not merging results for rows which had data for the same series. This change fixes this. Fixes issue #3242.
otoolep
changed the title
| @@ -31,6 +31,11 @@ type Row struct { | |||
| Err error `json:"err,omitempty"` | |||
| } | |||
|
|
|||
| // SameSeries returns true if r contains values for the same series as o. | |||
| func (r *Row) SameSeries(o *Row) bool { | |||
| return r.tagsHash() == o.tagsHash() && r.Name == o.Name | |||
There was a problem hiding this comment.
@jwilder -- you think this is OK?
|
+1 |
otoolep
added a commit
that referenced
this pull request
Aug 18, 2015
Merge same-series data if not chunking
dleutnant
added a commit
to dleutnant/influxdbr
that referenced
this pull request
Sep 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no chunking was requested by the user, the co-ordinating node buffers all results in RAM before emitting a single result. However buffering was not merging results for rows which had data for the same series. This change fixes this. Fixes issue #3242.
This issue has been present since before the distributed query work.