LIMIT seems broken #298
Merged
LIMIT seems broken #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, it might be giving you one result per shard. We'll have a look |
| // if we have a query with limit, then create an engine, or we can | ||
| // make the passthrough limit aware | ||
| shouldAggregateLocally = false | ||
| processor = engine.NewQueryEngine(querySpec.SelectQuery(), responseChan) |
There was a problem hiding this comment.
I think this is going to break in unexpected ways. Like if you do a percentile query, the engine will then try to compute percentiles on the already computed percentile results.
I think it's better to have the PassthroughEngine support limits and use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vers. 0.5-rc3
This query returns 12 results instead of one in the admin interface, "LIMIT 2" gives me 24. Same happens on other series too.
Those are the returned timestamps:
1393577978000
1393459205000
1392854405000
1392249604000
1391644808000
1391040004000
1390435202000
1390406899000
1381968002000
1381363201000
1380758405000
1380153601000
Do I get one result per shard?