You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ebb-tide
changed the title
Check in updated swagger API contract for alerts to influxdb
Check in updated swagger API contract for checks to influxdb
Jul 9, 2019
It seems like the alerts + notifications work will generate a steady stream of API changes, and it would be exhausting to have each change go through the whole cycle:
Checkout client
Regenerate swagger
Open client PR and get it reviewed
Merge client PR
Publish new version
Open PR in InfluxDB to integrate new client version + get it reviewed
This might be a good time to rethink this workflow. We talked at retro recently about moving the client back into the influxdb repo, since it's so painful / slow to keep it separate.
Also somewhat unrelated, but the types generated by openapi-generator are really poor—especially when it comes to OpenAPI enum types, of which there are many in the alerts + notifications API. Since we rely on types so much now for correctness and to catch breaking changes, I think it would be worthwhile to see if we can improve the type generation. I spiked on a OpenAPI spec to types generator a while back and it seemed pretty straightforward.
@chnn I would love to move the client into influxdb. The problems it solved are outweighed by the costs of its maintenance. Are you suggesting rolling our own types generator based on the OpenAPI spec?
Swagger API contract needs to be in influxdb master in order to generate types for influxdb js client.
The text was updated successfully, but these errors were encountered: