Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify telegraf config stuff #10771

Closed
leodido opened this issue Jan 9, 2019 · 3 comments
Closed

Clarify telegraf config stuff #10771

leodido opened this issue Jan 9, 2019 · 3 comments

Comments

@leodido
Copy link
Contributor

leodido commented Jan 9, 2019

Doing https://github.com/influxdata/platform/pull/2376 in order to scope telegraf configs to an organization I noticed that we should probably clarify better what their intended behavior is.

We should probably revisit the behavior and the interfaces (already slightly modified into such PR).

Furthermore HTTP test suite is pretty thin and this needs to be addressed too.

As note for future reference I copy here what emerged during chat with @desa.

/api/v2/telegrafs?id=1&id=2 -> should return telegrafs 1 and 2
/api/v2/telegrafs?orgID=5 -> all telegrafs that have organizationID 5
/api/v2/telegrafs?ownerID=10 -> all telegrafs that belong to that user
/api/v2/telegrafs?orgID=5&ownerID=10 -> all telegrafs from org 5 that belong to user 10
/api/v2/telegrafs?orgID=5&id=1 -> errors out, as id and orgID should be mutually exclusive

PR https://github.com/influxdata/platform/pull/2376 does not sync swagger for these exact reasons.

@leodido
Copy link
Contributor Author

leodido commented Jan 9, 2019

Also response format needs to change whenever we'll introduce links (as @goller noted out this into comments).

@stale
Copy link

stale bot commented Jul 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 23, 2019
@stale
Copy link

stale bot commented Jul 30, 2019

This issue has been automatically closed because it has not had recent activity. Please reopen if this issue is still important to you. Thank you for your contributions.

@stale stale bot closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants